Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug deleting bindings for service instance #2230

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 7, 2017

The logic checking if the binding was already deleted was flipped.

The logic checking if the binding was already deleted was flipped.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 7, 2017
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spadgett

@spadgett
Copy link
Member Author

spadgett commented Oct 9, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 4aa9a1c

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/323/) (Base Commit: 2e0fbe8) (PR Branch Commit: 4aa9a1c)

@openshift-bot openshift-bot merged commit 436cb11 into openshift:master Oct 9, 2017
@spadgett spadgett deleted the delete-instance-bindings branch October 9, 2017 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants